added blockhandler unit tests

.gitignore

@@ -173,5 +173,7 @@ UpgradeLog*.htm
 # Microsoft Fakes
 FakesAssemblies/
 
+scripts/xunit.runner.console.2.0.0/
+
 # vim swap files
 .*.sw*

Ficdown.Console/Program.cs

@@ -6,11 +6,22 @@
     using Microsoft.SqlServer.Server;
     using Parser;
     using Parser.Render;
+    using Parser.Model.Parser;
 
     internal class Program
     {
         private static int Main(string[] args)
         {
+            AppDomain.CurrentDomain.UnhandledException += (sender, e) =>
+            {
+                if(e.ExceptionObject is FicdownException)
+                {
+                    Console.ForegroundColor = ConsoleColor.Red;
+                    Console.Error.WriteLine(e.ExceptionObject.ToString());
+                    Environment.Exit(3);
+                }
+            };
+
             string infile = null;
             string output = null;
             string tempdir = null;
@@ -118,7 +129,10 @@
 
             story.Orphans.ToList().ForEach(o =>
             {
+                var currentColor = Console.ForegroundColor;
+                Console.ForegroundColor = ConsoleColor.Yellow;
                 Console.Error.WriteLine("Warning (line {0}): {1} {2} is unreachable", o.LineNumber, o.Type, o.Name);
+                Console.ForegroundColor = currentColor;
             });
 
             IRenderer rend;

Ficdown.Parser.Tests/BlockHandlerTests.cs

@@ -1,6 +1,120 @@
 namespace Ficdown.Parser.Tests
 {
+    using System;
+    using System.Linq;
+    using System.Collections.Generic;
+    using Xunit;
+    using Parser;
+    using Model.Parser;
+    using Extensions;
+
     public class BlockHandlerTests
     {
+        [Fact]
+        public void NoStoryBlockThrowsException()
+        {
+            var bh = new BlockHandler();
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+## this file has no story
+just a lonely scene".ToLines())));
+        }
+
+        [Fact]
+        public void StoryWithNoAnchorThrowsException()
+        {
+            var bh = new BlockHandler();
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+# my story
+doesn't link to a scene
+## a scene
+nothing links here".ToLines())));
+        }
+
+        [Fact]
+        public void StoriesWithFancyAnchorsThrowExceptions()
+        {
+            var bh = new BlockHandler();
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+# [my story](/a-scene?conditional)
+story with a conditional
+## a scene
+this is a scene".ToLines())));
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+# [my story](/a-scene#toggle)
+story with a toggle
+## a scene
+this is a scene".ToLines())));
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+# [my story](/a-scene#?conditional#toggle)
+story with a conditional and a toggle
+## a scene
+this is a scene".ToLines())));
+        }
+
+        [Fact]
+        public void StoryLinkingToNonExistentSceneThrowsException()
+        {
+            var bh = new BlockHandler();
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+# [a story](/non-existent)
+this story links to a first scene that doesn't exist
+## a scene
+this scene is so cold and lonely".ToLines())));
+        }
+
+        [Fact]
+        public void StoryWithALegitAnchorParses()
+        {
+            var bh = new BlockHandler();
+            bh.ParseBlocks(bh.ExtractBlocks(@"
+# [my story](/a-scene)
+story with a simple link
+## a scene
+this is a scene".ToLines()));
+        }
+
+        [Fact]
+        public void StoryWithDuplicateActionsThrowsException()
+        {
+            var bh = new BlockHandler();
+            Assert.Throws<FicdownException>(() => bh.ParseBlocks(bh.ExtractBlocks(@"
+# [a story](/a-scene)
+this story is action-happy
+## a scene
+this is the first scene
+### an action
+this is an action
+## another scene
+this is another scene
+### an action
+oops, this is the same action!".ToLines())));
+        }
+
+        [Fact]
+        public void StoryWithScenesAndActionsParses()
+        {
+            var bh = new BlockHandler();
+            var story = bh.ParseBlocks(bh.ExtractBlocks(@"
+# [my story](/a-scene)
+story with a simple link
+## a scene
+this is a scene
+## [a scene](?something)
+this is the same scene with a conditional
+## another scene
+this is another scene
+### action1
+this is an action
+### action 2
+this is another action
+## yet another scene
+yup here's some more
+### another action
+the last action (hero?)".ToLines()));
+
+            Assert.Equal(3, story.Scenes.Count);
+            Assert.Equal(2, story.Scenes["a-scene"].Count);
+            Assert.Equal(3, story.Actions.Count);
+        }
     }
 }

Ficdown.Parser.Tests/Extensions/TestExtensions.cs

@@ -0,0 +1,13 @@
+namespace Ficdown.Parser.Tests.Extensions
+{
+    using System;
+    using System.Collections.Generic;
+
+    public static class TestExtensions
+    {
+        public static IEnumerable<string> ToLines(this string content)
+        {
+            return content.Split(new[] {Environment.NewLine}, StringSplitOptions.None);
+        }
+    }
+}

Ficdown.Parser.Tests/Ficdown.Parser.Tests.csproj

@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
   <PropertyGroup>
@@ -58,6 +57,7 @@
       <DependentUpon>Resources.resx</DependentUpon>
     </Compile>
     <Compile Include="UtilityTests.cs" />
+    <Compile Include="Extensions\TestExtensions.cs" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />

Ficdown.Parser/Model/Parser/FicdownException.cs

@@ -4,31 +4,26 @@ namespace Ficdown.Parser.Model.Parser
 
     public class FicdownException : Exception
     {
-        private string _blockName;
+        public string BlockName { get; private set; }
-        private int? _lineNumber;
+        public int? LineNumber { get; private set; }
-        private string _message;
 
         public FicdownException(string blockName, int? lineNumber, string message) : base(message)
         {
-            _blockName = blockName;
+            BlockName = blockName;
-            _lineNumber = lineNumber;
+            LineNumber = lineNumber;
-            _message = message;
         }
 
-        public FicdownException(string message) : base(message)
+        public FicdownException(string message) : base(message) { }
-        {
-            _message = message;
-        }
 
         public override string ToString()
         {
-            return !string.IsNullOrEmpty(_blockName)
+            return !string.IsNullOrEmpty(BlockName)
                 ? string.Format("Error in block \"{0}\" (Line {1}): {2}",
-                    _blockName,
+                    BlockName,
-                    _lineNumber.HasValue
+                    LineNumber.HasValue
-                        ? _lineNumber.ToString()
+                        ? LineNumber.ToString()
-                        : "unknown", _message)
+                        : "unknown", Message)
-                : string.Format("Error: {0}", _message);
+                : string.Format("Error: {0}", Message);
         }
     }
 }

Ficdown.Parser/Parser/BlockHandler.cs

@@ -48,7 +48,15 @@
             var storyBlock = blocks.SingleOrDefault(b => b.Type == BlockType.Story);
             if(storyBlock == null) throw new FicdownException("No story block found");
 
-            var storyAnchor = Utilities.GetInstance(storyBlock.Name, storyBlock.LineNumber).ParseAnchor(storyBlock.Name);
+            Anchor storyAnchor;
+            try
+            {
+                storyAnchor = Utilities.GetInstance(storyBlock.Name, storyBlock.LineNumber).ParseAnchor(storyBlock.Name);
+            }
+            catch(FicdownException ex)
+            {
+                throw new FicdownException(ex.BlockName, ex.LineNumber, "Story block must be an anchor pointing to the first scene");
+            }
 
             if (storyAnchor.Href.Target == null || storyAnchor.Href.Conditions != null ||
                 storyAnchor.Href.Toggles != null)
@@ -70,8 +78,18 @@
                 story.Scenes[scene.Key].Add(scene);
             }
             var aid = 1;
+            try
+            {
                 story.Actions =
                     blocks.Where(b => b.Type == BlockType.Action).Select(b => BlockToAction(b, aid++)).ToDictionary(a => a.Toggle, a => a);
+            }
+            catch(ArgumentException)
+            {
+                var a = blocks.First(b => b.Type == BlockType.Action && blocks.Any(d => b != d && BlockToAction(b, 0).Toggle == BlockToAction(d, 0).Toggle));
+                var actionA = BlockToAction(a, a.LineNumber);
+                var dupe = blocks.First(b => b.Type == BlockType.Action && b != a && BlockToAction(b, 0).Toggle == actionA.Toggle);
+                throw new FicdownException(actionA.Toggle, actionA.LineNumber, string.Format("Action is defined again on line {0}", dupe.LineNumber));
+            }
 
             if (!story.Scenes.ContainsKey(storyAnchor.Href.Target))
                 throw new FicdownException(storyBlock.Name, storyBlock.LineNumber, string.Format("Story targets non-existent scene: {0}", storyAnchor.Href.Target));

scripts/build.sh

@@ -0,0 +1,4 @@
+#!/bin/sh
+
+DIR=`dirname $0`
+xbuild $DIR/../Ficdown.sln

scripts/rebuild.sh

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+DIR=`dirname $0`
+rm -rf $DIR/../*/bin $DIR/../*/obj
+xbuild $DIR/../Ficdown.sln

scripts/run.sh

@@ -0,0 +1,4 @@
+#!/bin/sh
+
+DIR=`dirname $0`
+mono $DIR/../Ficdown.Console/bin/Debug/Ficdown.Console.exe "$@"

scripts/test.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+DIR=`dirname $0`
+if [ ! -d "$DIR/xunit.runner.console.2.0.0" ]; then
+  nuget install xunit.runner.console -Version 2.0.0 -OutputDirectory $DIR
+fi
+mono --debug $DIR/xunit.runner.console.2.0.0/tools/xunit.console.exe $DIR/../Ficdown.Parser.Tests/bin/Debug/Ficdown.Parser.Tests.dll